[openstreetmap/openstreetmap-website] Facelift `offline.html` and use Bootstrap classes for "notifications" under the search bar (PR #3907)

[Dimitar]

@Dimitar5555 commented on this pull request.



> @@ -1,5 +1,5 @@
 <% if flash[:error] %>
-  <div class="flash error row mx-0 p-3 align-items-center">
+  <div class="alert alert-danger row mx-0 mb-0 p-3 rounded-0 align-items-center">

> If the `flash` CSS is no longer required elsewhere, then it should be removed from `common.scss`

There are quite a few tests which require the old classes and they were passing on the first test. Would it be OK if I update all instances of the current `flash` classes to `alert` (as well as their tests) or it would it be better to do it in a separate PR?

> Large numbers of tests are failing, since they are looking for the `flash` and `error` css classes. The tests need to be updated.

I've updated them. There should be only one failing about a `title` on the "Send message" page.





-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3907#discussion_r1086622819
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3907/review/1269320294 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230125/54c2d46f/attachment.htm>