[openstreetmap/openstreetmap-website] Change the way notifications about messages appear (PR #4070)

Andy Allan notifications at github.com
Fri Jul 7 08:14:34 UTC 2023


@Dimitar5555 My concern with this PR is that I think it breaks our UI conventions. You've used the "danger" colour to highlight something that I wouldn't normally put in that category. We use "danger" for things like actions that cannot be reversed, or errors that can't be recovered from. We use warnings for things of lesser importance, like when the whole service is read-only or when there's (recoverable) errors in form submissions. 

But this makes me think that a "unread message count" status indicator wouldn't qualify even for a warning level, never mind our danger level.

I'm happy to hear your thoughts, but otherwise I'm minded to decline this proposal.

(As an aside, I'd be happy to see colour consistency between the number shown on the collapsed and expanded menus, and if this used a "information" level bootstrap class then so much the better!)

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4070#issuecomment-1624993121
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4070/c1624993121 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230707/2088f04a/attachment.htm>


More information about the rails-dev mailing list