[openstreetmap/openstreetmap-website] Avoid using sprockets for combining stylesheets (PR #4088)
Andy Allan
notifications at github.com
Wed Jul 12 16:57:11 UTC 2023
There are two options for combining stylesheets, using sprockets (via `require` statements) or using sass (via `@import` statements).
This commit switches to using `@import` statements throughout, to avoid a bug with libsass that prevents us from using bootstrap 5.2+
See https://github.com/sass/sassc-rails/issues/174
Since R2 is not triggered when `@import`ing a file, we need to switch the top-level stylesheet names to include the extension. We can also take the opportunity to remove a level of indirection, along with removing symlinks which cause problems on some platforms.
* https://github.com/openstreetmap/openstreetmap-website/issues/3984
* https://github.com/openstreetmap/openstreetmap-website/issues/3422
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/4088
-- Commit Summary --
* Avoid using sprockets for combining stylesheets
-- File Changes --
D app/assets/stylesheets/ltr/common.scss (1)
D app/assets/stylesheets/print-ltr.css (3)
A app/assets/stylesheets/print-ltr.scss (1)
D app/assets/stylesheets/print-rtl.css (3)
A app/assets/stylesheets/print-rtl.r2.scss (1)
R app/assets/stylesheets/print.scss (0)
D app/assets/stylesheets/rtl/common.r2.scss (1)
D app/assets/stylesheets/screen-ltr.css (3)
A app/assets/stylesheets/screen-ltr.scss (1)
D app/assets/stylesheets/screen-rtl.css (3)
A app/assets/stylesheets/screen-rtl.r2.scss (1)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/4088.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4088.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4088
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4088 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230712/9b2ac520/attachment-0001.htm>
More information about the rails-dev
mailing list