[openstreetmap/openstreetmap-website] Replace page numbers with ID based selection for trace indexes (PR #4089)

Tom Hughes notifications at github.com
Wed Jul 12 18:45:30 UTC 2023


This allows us to avoid horribly inefficient queries when people try and fetch ever large page numbers for the trace list forcing us to read ever large number of records.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4089

-- Commit Summary --

  * Replace page numbers with ID based selection for trace indexes

-- File Changes --

    M app/controllers/traces_controller.rb (8)
    M app/views/traces/_trace_paging_nav.html.erb (10)
    M app/views/traces/index.html.erb (20)
    M config/routes.rb (12)
    M test/controllers/traces_controller_test.rb (24)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4089.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4089.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4089
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4089 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230712/79e8c02e/attachment.htm>


More information about the rails-dev mailing list