[openstreetmap/openstreetmap-website] Replace page numbers with ID based selection for trace indexes (PR #4089)

[Andy Allan]

@gravitystorm commented on this pull request.



> @@ -8,51 +8,27 @@ def test_routes
       { :path => "/traces", :method => :get },
       { :controller => "traces", :action => "index" }
     )
-    assert_routing(
-      { :path => "/traces/page/1", :method => :get },
-      { :controller => "traces", :action => "index", :page => "1" }
-    )

Yeah, I think since there's no controller involved in a redirect, it's not going to work with those assertions. https://stackoverflow.com/a/10844398/105451 has a reasonably well researched take on this, to do with how the routes are handled differently internally to rails when it's a redirect.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4089#discussion_r1268511962
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4089/review/1537778628 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230719/aa44b0cb/attachment-0001.htm>