[openstreetmap/openstreetmap-website] Remove incorrect language blocks from copyright page (PR #3981)

Andy Allan notifications at github.com
Wed Mar 22 10:07:40 UTC 2023


This PR removes two incorrect language blocks declarations from the copyright page. In both cases, the text is shown in the users native language that is used for the rest of the page (i.e. there are no `@locale` overrides) and so no additional language declarations are required for those parts of the page.

Although marking the language incorrectly in html doesn't have much of a user-visible impact, the dir attribute causes problems that are easier to see. If you set your language preference to `ar` and view the copyright page, then you will see Arabic written LTR due to these incorrect declarations.

![Screenshot from 2023-03-22 10-00-52](https://user-images.githubusercontent.com/360803/226868848-81de9335-7504-4cf0-ac99-3e258b263cea.png)

The solution is to remove them, while keeping the language (and direction) overrides for the parts of the page that use the `@locale` override.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/3981

-- Commit Summary --

  * Remove the language block from around the guidance
  * Remove the language block from around the original guidance

-- File Changes --

    M app/views/site/copyright.html.erb (42)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/3981.patch
https://github.com/openstreetmap/openstreetmap-website/pull/3981.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/3981
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/3981 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230322/21e30741/attachment.htm>


More information about the rails-dev mailing list