[openstreetmap/openstreetmap-website] Add OpenMapTiles vector map (PR #4042)

Andy Allan notifications at github.com
Tue May 23 14:46:54 UTC 2023


Great to see progress on this, thank you for the PR.

> The main advantage for users is support for labels in multiple languages: users can easily switch by changing language preferences in settings.

This is great! Do you have any guidance for us as to how it handles regional languages, e.g. `pt-PT` vs `pt-BR`? Or `sr` vs `sr-Latn`? And what happens if you pick a language that is not supported by GL-based renderings, like `my` (Burmese)?

I want to make sure that the translations work for all of the [languages that our user interface works in](https://github.com/openstreetmap/openstreetmap-website/tree/master/config/locales), hopefully so that there's no mismatch between what you can pick in the UI and what then happens with this layer.

I also noticed on the wiki that it says "map labels translations from Wikidata" - can you clarify this? How does this interact with the translated labels available in OSM? If a contributor spots a mistake on the map, can they edit OSM to fix it, or do they have to edit something on Wikidata?

> We added it there to allow visitors to see the OSM in 3D. We would love to have it directly on [osm.org](http://osm.org/). However, it is not technically possible because the site runs on Leaflet. Therefore, we added it at least as an external link.

I don't think the layer attribution is the right place for linking to external sites to view other renderings. 

If we want to link to external sites to view other renderings, which haven't been through the new layer approval process, then let's discuss this separately. And if we want to adapt the site to support alternative (i.e. non-leaflet) tech, then let's discuss that separately too. But I don't think such links should be part of the attribution for another layer, and I definitely don't think that should be part of this PR.



-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4042#issuecomment-1559579193
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4042/c1559579193 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230523/bd66d5b0/attachment.htm>


More information about the rails-dev mailing list