[openstreetmap/openstreetmap-website] Silence image_optim warnings in development (PR #4055)
Andy Allan
notifications at github.com
Wed May 31 16:49:06 UTC 2023
Lots of new developers see this during configuration (e.g. rails db:migrate) and then spend time trying to fix them, by figuring out what packages are missing (or just worrying that something is wrong). So let's silence the warnings entirely in the development environment.
An alterative would be to expand the installation instructions to add all the additional packages, but this just makes the (already lengthy) installation process take more time, for little gain.
I was surprised to find this topic mentioned in #4038 since it's been so long since I've seen the warnings. But then I found that I've created this file (and locally ignored it using .git/info/excludes) many years ago. So I think it's reasonable to have the same approach happen out-of-the-box for new developers.
The main argument against doing this is that it's less noticeable the the packages are missing if you want to set up a fully-optimised production environment. But in this case, I'd rather optimise for a smoother first-time-developer experience.
Refs #1795 where we disabled the warnings in the test environment.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/4055
-- Commit Summary --
* Silence image_optim warnings in development
-- File Changes --
A config/image_optim/development.yml (12)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/4055.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4055.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4055
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4055 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230531/87fde47e/attachment.htm>
More information about the rails-dev
mailing list