[openstreetmap/openstreetmap-website] Discard deserialize errors (PR #4323)
Tom Hughes
notifications at github.com
Sat Nov 4 10:17:41 UTC 2023
This attempts to ensure that background jobs which fail to deserialise are discarded rather than retrying multiple times which is unlikely to achieve anything.
The main cause of such errors is database objects being deleted before the job runs - for example somebody adding a friend and then removing them again before the mail job runs causing a failure to find the friendship when the job runs.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/4323
-- Commit Summary --
* Set delivery job class for mailers globally
* Discard jobs that fail to deserialize
-- File Changes --
M app/jobs/application_job.rb (6)
A app/jobs/mail_delivery_job.rb (3)
M app/mailers/application_mailer.rb (1)
M app/mailers/user_mailer.rb (2)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/4323.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4323.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4323
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4323 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20231104/e56c5f81/attachment.htm>
More information about the rails-dev
mailing list