[openstreetmap/openstreetmap-website] Welcome page interrupts Oauth authorization flow for newly created OSM accounts (Issue #4246)

[Milan Cvetkovic]

@AntonKhorev I have tested #4329 with [osm-auth demo app](https://osmlab.github.io/osm-auth/). I found out that you are correct that clicking a link in email does not close the window from which the email was originally triggered (2nd browser window appearing as a popup). Instead, it opens up the new tab in the default browser and continues the authorization process - if this is the same browser, and if it was clicked within a reasonable time. The final state is:
 - new user is registered with OSM
 - application is authorized with OSM
 - popup window displays "We have sent you confirmation email" page. It is not and cannot be closed by link in the confirmation email.
 - the browser tab opened by confirmation email does not work properly. Note that this page is hosted by the client app - in osm-auth's `land.html` in this example. 

Similarly, in single page mode "We have sent you confirmation email" page stays untouched after user clicks the link in confirmation email, and the authorization is completed in the newly opened tab or window.

In summary, I believe that #4329 does not degrade UX in any scenario, but significantly improves it when confirmation email is not required, and in many cases when it is.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/4246#issuecomment-1810887001
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/issues/4246/1810887001 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20231114/387d5a1e/attachment.htm>