[openstreetmap/openstreetmap-website] Format right-to-left and bi-di text in OSM tag values (PR #4333)
Andy Allan
notifications at github.com
Wed Nov 15 15:23:23 UTC 2023
Hi @mapmeld thanks for your pull request.
This PR addresses one small part of #3428 (and see also #3429 which mostly implements the rest, but is not yet merged).
Have you considered also setting dir=auto for keys? I know the convention in OSM is to use (mostly) English-language keys, but if we are establishing that all user-generated-content should be `dir="auto"` as part of the wider work, then perhaps we should consider setting it for keys here too. What do you think?
In any case, there has been other work on this file since your PR was created, so it needs to be rebased before we can merge it. Can you take care of that too please?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4333#issuecomment-1812739184
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4333/c1812739184 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20231115/f7ad7049/attachment.htm>
More information about the rails-dev
mailing list