[openstreetmap/openstreetmap-website] Improve handling of RTL styling (PR #4353)
Andy Allan
notifications at github.com
Wed Nov 22 16:20:35 UTC 2023
> So this PR switches our RTL support to use RTLCSS meaning that those directives are obeyed and various bugs go away and overrides in our source can be removed - it also gives us access to a much richer set of customisation directives for future use.
Awesome, thanks for digging into this.
> After all that I hit [rubyjs/mini_racer#289](https://github.com/rubyjs/mini_racer/issues/289) which prevents `mini_racer` installing in the GitHub Actions ruby 3.0 or 3.1 environments - sadly upstream seem to have given up on it once they figured out 3.2 works but I managed to find a workaround after much digging.
Not just github actions, because I ran into this with my own system too (I'm using ruby 3.0 for this project).
I'm going to open a separate issue to discuss this since it's not directly related to RTLCSS.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4353#issuecomment-1823080985
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4353/c1823080985 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20231122/7c3d4d4c/attachment-0001.htm>
More information about the rails-dev
mailing list