[openstreetmap/openstreetmap-website] Remove <picture> from logo in header (PR #4269)

Anton Khorev notifications at github.com
Mon Oct 2 01:20:56 UTC 2023


A `picture` element was added to show svg logo in https://github.com/openstreetmap/openstreetmap-website/commit/ecc4b64a23d0d27d5a1a2eb472082123cdf985cd. Then a `srcset` attribute was added in case `picture` is not supported in https://github.com/openstreetmap/openstreetmap-website/commit/37a4fc6dd14dfedc0c44a8d7bf6453df0db9e1b5. But why do you need both nowadays? Basic `<img src...>` is supported by anything, so if some browser doesn't understand `srcset`, there's a fallback.

(I know that picture+srcset is used similarly in several other places. I'm not removing picture everywhere in case I'm wrong.)
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4269

-- Commit Summary --

  * Remove <picture> from logo

-- File Changes --

    M app/views/layouts/_header.html.erb (5)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4269.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4269.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4269
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4269 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20231001/f255d64d/attachment.htm>


More information about the rails-dev mailing list