[openstreetmap/openstreetmap-website] Upgrade to rails 7.1.0 (PR #4278)
Tom Hughes
notifications at github.com
Wed Oct 11 16:19:05 UTC 2023
@tomhughes commented on this pull request.
> # config.require_master_key = true
- # Disable serving static files from the `/public` folder by default since
- # Apache or NGINX already handles this.
- config.public_file_server.enabled = ENV["RAILS_SERVE_STATIC_FILES"].present?
This was also just a change in upstream defaults I think - as far as I know our old code was just the default and we never use that environment variable.
You're right that we use apache to serve the files, but that means rails never sees the request so whether it is also prepared to serve them won't matter and I guess other users of the code might be running in production with different setups?
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4278#discussion_r1355334066
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4278/review/1671803067 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20231011/72bfe815/attachment-0001.htm>
More information about the rails-dev
mailing list