[openstreetmap/openstreetmap-website] .github/workflows/lint.yml: Check if annotate_models is up to date (PR #4286)
Gregory Igelmund
notifications at github.com
Sat Oct 14 03:43:34 UTC 2023
I do not like rewriting the commit history in a PR with attached inline comments. It creates dangling comments and makes it harder to understand the PR history and structure retrospectively.
I'll create a new PR with the commits as you described.
---
On that note a question. I understand that PRs in this repo are committed with Merge Commits, which explains why it's preferred to have a clean commit history in each PR.
In the past years I've worked exclusively in projects squash-merging PRs. Why are Merge Commits the preferred way to merge and not squash-merging?
_I do not want to promote squash-merging here. Just want to understand why Merge Commits are preferred._
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4286#issuecomment-1762548087
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4286/c1762548087 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20231013/94e50c45/attachment.htm>
More information about the rails-dev
mailing list