[openstreetmap/openstreetmap-website] Remove some tag table custom css (PR #4297)

Anton Khorev notifications at github.com
Wed Oct 18 14:05:40 UTC 2023


I think @gravitystorm used tags table as an example of what's to be converted to Bootstrap, like in https://github.com/openstreetmap/openstreetmap-website/pull/3535#issuecomment-1125113979. I don't think think it's a good example because Bootstrap doesn't have:
- `table-layout: fixed`
- `white-space: pre-wrap`
- `border-collapse: separate`, which is required for rounded corners directly on the table
- without `border-collapse: separate` you need a wrapper with a border and rounded corners, then you can't use Bootstrap's bordered table class because it will have an outer border which you don't need.
- actually you could use `box-shadow` instead of a wrapper to draw a border, but Bootstrap doesn't have that too
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4297

-- Commit Summary --

  * Remove some tag table custom css

-- File Changes --

    M app/assets/stylesheets/common.scss (31)
    M app/helpers/browse_tags_helper.rb (2)
    M app/views/browse/_tag.html.erb (4)
    M app/views/browse/_tag_details.html.erb (8)
    M test/helpers/browse_tags_helper_test.rb (2)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4297.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4297.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4297
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4297 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20231018/37a37c02/attachment.htm>


More information about the rails-dev mailing list