[openstreetmap/openstreetmap-website] Welcome page interrupts Oauth authorization flow for newly created OSM accounts (Issue #4246)

[Branko Kokanovic]

>  If I read the description text of this issue, then the actual problem is the interruption of flow because of the confirmation email,

I guess confusion comes because there are multiple interruption flows (what we identified). They are discussed broadly in #4128 . And because it can be confusing, we decided to focus here _only_ on "welcome page" issue. One interruption is for confirmation mails, yes, but this interruption is because "welcome" page is stopper - user cannot go back from welcome screen to originated application that issues singup request and this PR fixes it. I guess original text of this issue clarified this better than me here:)

> Well I made it very clear that if we were going to change how the welcome page is displayed then it should be for all signups not just those happening via OAuth but the PR seems to have ignored that :-(

If you noticed in PR, @milan-cvetkovic [commented on it](https://github.com/openstreetmap/openstreetmap-website/pull/4288#discussion_r1358483731) and requested help how best to extract/pull welcome page text to be referenced by both mail and html parts. It is not that we ignored it or that we don't want to do it, but more that we need guidance on this:/


-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/4246#issuecomment-1770563507
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/issues/4246/1770563507 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20231019/6ad99b5b/attachment-0001.htm>