[openstreetmap/openstreetmap-website] Account deletion cool-down period (PR #4313)

[Tom Hughes]

@tomhughes commented on this pull request.



> @@ -31,5 +31,13 @@
   <li><%= t ".retain_email" %></li>
 </ul>
 
-<%= link_to t(".delete_account"), account_path, { :method => :delete, :class => "btn btn-danger", :data => { :confirm => t(".confirm_delete") } } %>
+<% if @allowed_at %>
+  <div class="alert alert-warning">
+    <%= t ".recent_editing_html", :time => friendly_date_time_element(@allowed_at) %>
+  </div>
+  <button class="btn btn-danger" disabled><%= t(".delete_account") %></button>

I wonder if we should just leave the button out when deletion is not possible? Even a disabled "danger" button still looks very clickable - the difference to a non-disabled one is quite subtle.

> @@ -53,6 +53,8 @@ api_timeout: 300
 web_timeout: 30
 # Periods (in hours) which are allowed for user blocks
 user_block_periods: [0, 1, 3, 6, 12, 24, 48, 96, 168, 336, 731, 4383, 8766, 87660]
+# Account deletion cooldown period since last changeset close (in hours)
+user_account_deletion_delay: 24

Do we want to have a default for this? or should it default to off but be something we can enable operationally? In other words should we assume that other users of this code will want this.

> @@ -256,6 +256,7 @@ en:
         retain_notes: Your map notes and note comments, if any, will be retained but hidden from view.
         retain_changeset_discussions: Your changeset discussions, if any, will be retained.
         retain_email: Your email address will be retained.
+        recent_editing_html: "Due to your recent editing activity you'll be able to delete your account in %{time}"

This doesn't read very well to me but I'm struggling to come up with a better phrasing, at least as a single sentence. The best I've come up with is:

> As you have edited recently your account cannot currently be deleted.
> Deletion will be possible in %{time}. 

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4313#pullrequestreview-1695904483
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4313/review/1695904483 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20231024/1ccba36f/attachment.htm>