[openstreetmap/openstreetmap-website] Welcome page interrupts Oauth authorization flow for newly created OSM accounts (Issue #4246)

[Milan Cvetkovic]

> If we're making the change to email I would assume it would happen for everyone. I'm not keen on the idea of having two versions of the information (which will doubtless get out of sync) depending on how you sign up.
...
> Well I made it very clear that if we were going to change how the welcome page is displayed then it should be for all signups not just those happening via OAuth but the PR seems to have ignored that :-(

@tomhughes
Can you please clarify what you had in mind - did you envision complete substitution of welcome page with welcome emails?

I tried to keep the flow unaffected for users signing up with OSM directly - they end up on Welcome page after confirming the email (by clicking the link in the email).  I had hoped to reuse the same set of messages when generating email for signups due to Oauth authorization request. However, `en.yml` appears to be organized in such a way that it discourages reusing strings. I would be grateful for a proposal for under which root to place those messages to be shared between mail and html.


-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/issues/4246#issuecomment-1787453197
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/issues/4246/1787453197 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20231031/311573e9/attachment-0001.htm>