[openstreetmap/openstreetmap-website] Add bbox parameter to notes search api (PR #4222)
Anton Khorev
notifications at github.com
Sun Sep 3 08:04:07 UTC 2023
This is an alternative to #3605.
#3605 adds the time `from`/`to` parameters to the index endpoint that already supports the `bbox`, this PR adds `bbox` to the search that already supports `from`/`to`.
You may want this PR if:
- The index endpoint is to be kept as simple as possible. The index endpoint is probably used more frequently because of the notes layer. Maybe you want to optimize it further, for example, by implementing it in cgimap. In this case the fewer parameters it has, the better.
- Changesets search already supports `bbox`.
For the use case described in #3605 you can switch over from the index endpoint to search if you want to download more notes.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/4222
-- Commit Summary --
* Add bbox parameter to notes search api
-- File Changes --
M app/controllers/api/notes_controller.rb (37)
M test/controllers/api/notes_controller_test.rb (31)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/4222.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4222.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4222
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4222 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230903/68d0ce63/attachment-0001.htm>
More information about the rails-dev
mailing list