[openstreetmap/openstreetmap-website] Updates for map-ui panels (PR #4233)

Andy Allan notifications at github.com
Wed Sep 6 16:07:32 UTC 2023


This PR updates the map-ui panels (share, key and layers panels, typically shown on the right hand side). It brings the margins and paddings into alignment with the main panel (i.e. using bootstrap `$spacer`, `p-3` or `m-3` sized gap) rather than the previously different sized margins and paddings.

It also updates the share panel to use bootstrap controls, most noticeably for the image section. I tried many ways of laying out the controls to work at all screen widths, but this was the best that I came up with - pretty much as before!

![Screenshot from 2023-09-06 16-54-37](https://github.com/openstreetmap/openstreetmap-website/assets/360803/02cd91e6-48ed-45ff-9d92-4658c67b202f)

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4233

-- Commit Summary --

  * Use bootstrap for share forms
  * Use bootstrap form controls for the link and html controls
  * Make the sharing controls read-only
  * Round the clickable map previews on the layer switcher
  * Use standard padding size for map-ui sidebar
  * Use h2 as the main header on the map-ui panel
  * Match the top spacing of the leaflet buttons to the gap between groups

-- File Changes --

    M app/assets/javascripts/leaflet.layers.js (3)
    M app/assets/javascripts/leaflet.share.js (105)
    M app/assets/javascripts/leaflet.sidebar-pane.js (4)
    M app/assets/stylesheets/common.scss (30)
    M app/views/site/key.html.erb (2)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4233.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4233.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4233
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4233 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230906/d5a5c70d/attachment.htm>


More information about the rails-dev mailing list