[openstreetmap/openstreetmap-website] Before/after id pagination for user diary comments (PR #4239)
Anton Khorev
notifications at github.com
Fri Sep 8 07:50:41 UTC 2023
for `/user/<username>/diary/comments` pages
similar to diary entry and trace pagination
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/4239
-- Commit Summary --
* Change diary comments pagination to before/after id
* Refactor diary paging queries
* Make pagination partial view
* Don't interpolate in pagination partial
* Combine comments and traces pagination partials
-- File Changes --
M app/controllers/diary_entries_controller.rb (46)
M app/views/diary_entries/comments.html.erb (10)
M app/views/diary_entries/index.html.erb (28)
A app/views/shared/_pagination.html.erb (23)
D app/views/traces/_trace_paging_nav.html.erb (23)
M app/views/traces/index.html.erb (12)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/4239.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4239.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4239
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4239 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230908/aae630fe/attachment-0001.htm>
More information about the rails-dev
mailing list