[openstreetmap/openstreetmap-website] Add openid connect support using doorkeeper-openid_connect gem (PR #4226)

[Milan Cvetkovic]

@milan-cvetkovic commented on this pull request.



> @@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+Doorkeeper::OpenidConnect.configure do
+  issuer do |_resource_owner, _application|
+    "https://www.openstreetmap.org/oauth2"

Is the value of `Settings.server_url` set to www.openstreetmap.org, and `Settings.server_protocol` to `https` in production? The template in Settings.yml shows different values.

Based on https://openid.net/specs/openid-connect-discovery-1_0.html#ProviderMetadata, the value should be same as what webfinger returns, although this is somewhat conflicting in development environment - `http://localhost:3000/`.

Assuming Settings.server_url and server_protocol are set to https://www.openstreetmap.org, we should use
`"#{Settings.server_protocol}://#{Settings.url}"`


-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4226#discussion_r1324552735
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4226/review/1624611951 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230913/b77a2a67/attachment.htm>