[openstreetmap/openstreetmap-website] Update Dockerfile to include image manipulation binaries. (PR #4254)

Andy Allan notifications at github.com
Wed Sep 20 09:41:34 UTC 2023


There should be no warnings emitted in either the development or test environments - see https://github.com/openstreetmap/openstreetmap-website/pull/4055 and https://github.com/openstreetmap/openstreetmap-website/pull/1795

I can see from a brief check at https://github.com/OpenHistoricalMap/ohm-website/tree/staging/config/image_optim that you are missing the config file from #4055, so my recommendation would be to merge that into your tree and you'll see the warnings disappear.

As @tomhughes says, we found that disabling them in test and development was the better approach, since it's a lot more packages to install for practically no (non-production) benefit - it's not worth the hassle for new developers. Particularly since there are often packaging issues too!

As for the MacOSX instructions, these should be updated to remove the unnecessary packages, but I would appreciate any assistance on that topic from someone who can test the instructions and make sure they are still accurate afterwards (i.e. removing a package doesn't unexpectedly remove a dependency that was actually necessary).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4254#issuecomment-1727358124
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4254/c1727358124 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230920/1582cd32/attachment.htm>


More information about the rails-dev mailing list