[openstreetmap/openstreetmap-website] Don't include unused bootstrap css (PR #4250)

[Andy Allan]

In effect this is the opposite of https://github.com/openstreetmap/openstreetmap-website/pull/2560 where I included all of bootstrap (after solving various compatibility issues with our pre-bootstrap custom stylesheets).

At that time I wanted to include everything by default, in order to make it easier for other developers to use any component they see when reading the bootstrap documentation. So my hesitation here is that by customising the list of components to restrict it to only those that are in use today, it makes it slightly harder to use new components (or components that are added in future versions of bootstrap). For example, if someone has an idea of how to improve a page (e.g. the about page) by adding a component (e.g. breadcrumbs or carousel or something new in 5.4 etc), would they figure out why it's not working, or would they just give up first? What do you think?

> Actually I do this to modify Bootstrap's theme colors. It has to be done after importing variables

Can you expand on this please, perhaps with an example? We already change some of the theme colours in parameters.scss, which is included before bootstrap. [Bootstrap sets its variables with the `!default` flag to allow this](https://getbootstrap.com/docs/5.1/customize/sass/#variable-defaults). Are you trying to do something different or more advanced than this?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4250#issuecomment-1727769752
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4250/c1727769752 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20230920/fa15d6b8/attachment.htm>