[openstreetmap/openstreetmap-website] Simplify api element paths in tests (PR #4641)

Anton Khorev notifications at github.com
Tue Apr 2 13:03:02 UTC 2024


Like #4591 etc.

One goal was to get rid of explicit `id` parameters because if I make old elements subresources of current elements, rails would want `node_id`/`way_id`/`relation_id` instead of `id`. Old element models already have these fields.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4641

-- Commit Summary --

  * Simplify element multi fetch paths in api tests
  * Simplify element show paths in api tests
  * Simplify old element show paths in api tests
  * Simplify element history paths in api tests
  * Simplify redact element paths in api tests

-- File Changes --

    M test/controllers/api/changesets_controller_test.rb (6)
    M test/controllers/api/nodes_controller_test.rb (20)
    M test/controllers/api/old_nodes_controller_test.rb (56)
    M test/controllers/api/old_relations_controller_test.rb (42)
    M test/controllers/api/old_ways_controller_test.rb (46)
    M test/controllers/api/relations_controller_test.rb (50)
    M test/controllers/api/ways_controller_test.rb (14)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4641.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4641.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4641
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4641 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240402/b45416b8/attachment.htm>


More information about the rails-dev mailing list