[openstreetmap/openstreetmap-website] Take rss/upload buttons out of trace nav tabs list (PR #4645)

Anton Khorev notifications at github.com
Wed Apr 3 13:12:10 UTC 2024


*** this works, but I want to try another thing first ***

---

Here's the trace navigation:
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/529a6437-b1ca-4d31-a603-0f782e73b923)

What if we make the window smaller? It won't look as good because the active tab is detached from the page contents:
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/2ccfd4be-b5f4-41bd-b1ed-bcc9f3bc2880)

After the fix in this PR:
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/e31d9197-fc14-4466-8ea3-b832ae0a7fbd)

---

![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/13eaab84-5a66-4783-8c6f-9d0fe74befbb)

After:
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/8e333e40-720f-4d1a-9a41-466396f09932)

https://github.com/openstreetmap/openstreetmap-website/commit/81ad7154747244abfa2e38dc529e62e6bd8998bd
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4645

-- Commit Summary --

  * Don't stretch trace tabs to full width on small screens
  * Take rss/upload buttons out of trace nav tabs list

-- File Changes --

    M app/views/traces/index.html.erb (92)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4645.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4645.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4645
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4645 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240403/b45aaca6/attachment.htm>


More information about the rails-dev mailing list