[openstreetmap/openstreetmap-website] Use secondary text color in header menu (PR #4661)

[Anton Khorev]

Uses `text-secondary` or `text-secondary-emphasis` if it's a current page.
Replaces: 
- `$darkgrey`: `text-secondary` matches it
- `darken($darkgrey, 25%)`: in dark mode it shouldn't be darkened

Before:
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/b02c5688-f069-4137-b6fd-b1932aaba7d4)

After:
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/4d3825c6-a62c-4d8b-85e5-719748ec8d96)

I also removed the current page color change in more/user dropdowns because it worked in the opposite direction, making the text lighter.

Before, with "Communities" as the current page:
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/802f9d86-57e1-4a91-bbde-6b81ca4f55e5)

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4661

-- Commit Summary --

  * Use secondary text color in header menu

-- File Changes --

    M app/assets/stylesheets/common.scss (5)
    M app/helpers/application_helper.rb (4)
    M app/views/layouts/_header.html.erb (42)
    M test/helpers/application_helper_test.rb (2)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4661.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4661.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4661
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4661 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240408/3d5e5e05/attachment-0001.htm>