[openstreetmap/openstreetmap-website] Adapt messages table to dark mode (PR #4703)

Anton Khorev notifications at github.com
Mon Apr 15 01:26:49 UTC 2024


- I remove the custom *unread message* background and replace it with `table-success`. The custom background was applied directly to table cells which we presumably don't want. This changes the green color used in the table.
- I extend dark mode overrides to cover `table-success`.
- I remove the `inbox-row` class. It was also used in the outbox.

Light mode before:
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/d5a83e6b-a985-471f-9c64-0ca66cbf4edc)

Light mode after:
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/6a8e5840-2a05-4118-aab9-3bbf8b3d2149)

Dark mode after:
![image](https://github.com/openstreetmap/openstreetmap-website/assets/4158490/74200ed6-ca10-4992-98a0-f3b5d7cddf2a)

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/4703

-- Commit Summary --

  * Test rows inside messages table body
  * Remove .inbox-row and use .table-success instead of .inbox-row-unread
  * Override .table-success in dark mode

-- File Changes --

    M app/assets/stylesheets/common.scss (13)
    M app/views/messages/_message_summary.html.erb (4)
    M app/views/messages/_sent_message_summary.html.erb (4)
    M test/controllers/messages_controller_test.rb (12)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/4703.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4703.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4703
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4703 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240414/54defa9c/attachment.htm>


More information about the rails-dev mailing list