[openstreetmap/openstreetmap-website] Adapt messages table to dark mode (PR #4703)
Anton Khorev
notifications at github.com
Mon Apr 15 01:26:49 UTC 2024
- I remove the custom *unread message* background and replace it with `table-success`. The custom background was applied directly to table cells which we presumably don't want. This changes the green color used in the table.
- I extend dark mode overrides to cover `table-success`.
- I remove the `inbox-row` class. It was also used in the outbox.
Light mode before:

Light mode after:

Dark mode after:

You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/4703
-- Commit Summary --
* Test rows inside messages table body
* Remove .inbox-row and use .table-success instead of .inbox-row-unread
* Override .table-success in dark mode
-- File Changes --
M app/assets/stylesheets/common.scss (13)
M app/views/messages/_message_summary.html.erb (4)
M app/views/messages/_sent_message_summary.html.erb (4)
M test/controllers/messages_controller_test.rb (12)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/4703.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4703.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4703
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4703 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240414/54defa9c/attachment.htm>
More information about the rails-dev
mailing list