[openstreetmap/openstreetmap-website] Center the nav links vertically (PR #4723)

Tom Hughes notifications at github.com
Fri Apr 26 17:00:31 UTC 2024


@tomhughes commented on this pull request.

The vertical alignment looks much better which is great but at least in Firefox the horizontal spacing between the items is reduced - the cause seems to be that previously the DOM put a whitespace item between each list item and that is gone with the flex layout.

Adding a one pixel margin on the list item seems to get it back to roughly where it was before but maybe there's a better solution or maybe people think the reduced spacing is ok?



-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4723#pullrequestreview-2025484914
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4723/review/2025484914 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240426/bc81567f/attachment.htm>


More information about the rails-dev mailing list