[openstreetmap/openstreetmap-website] Set trace thumbnail link display property to inline-block, fixing focus outline (PR #4744)
Anton Khorev
notifications at github.com
Tue Apr 30 14:23:45 UTC 2024
Try to move keyboard focus to a trace thumbnail while on a trace list page. This is what you'll see in Firefox:

After the fix:

`<img>` is an inline element by default, `<a>` is also an inline element, so a link with a thumbnail inside is as tall as a line of text. And it's shorter than the actual image size. You can see this in browser dev tools, both in Firefox and in Chrome. Chrome still draws the outline around the image but Firefox doesn't.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/4744
-- Commit Summary --
* Set trace thumbnail link display property to inline-block, fixing focus outline
-- File Changes --
M app/views/traces/_trace.html.erb (4)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/4744.patch
https://github.com/openstreetmap/openstreetmap-website/pull/4744.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4744
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/4744 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240430/b16b1123/attachment.htm>
More information about the rails-dev
mailing list