[openstreetmap/openstreetmap-website] Trace import: remove activerecord-import gem (PR #5038)
mmd
notifications at github.com
Thu Aug 1 18:26:12 UTC 2024
This PR removes the activerecord-import dependency and changes the tracepoint import to use `import_all!` instead.
I hope I didn't miss anything here. In particular `Tracepoint.insert_all!(tracepoints.map(&:attributes))` would need a review if that's the proper way to import Tracepoint instances.
Fixes #4994
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5038
-- Commit Summary --
* Trace import: remove activerecord-import gem
-- File Changes --
M .rubocop.yml (1)
M Gemfile (1)
M Gemfile.lock (3)
M app/models/trace.rb (4)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/5038.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5038.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5038
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5038 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240801/767160c6/attachment-0001.htm>
More information about the rails-dev
mailing list