[openstreetmap/openstreetmap-website] JSON partial rendering in loop (PR #5044)

mmd notifications at github.com
Sun Aug 4 20:01:54 UTC 2024


Similar to the change in #4958, this PR addresses the remaining locations where JSON partials were rendered in a loop, instead of using collections.

NB: 6268335ccdcdcb6629f32e5cae0d182c05b5593a has a typo in the description, it should read "Notes".  I split this up into multiple commits, since the changes are in different parts of the API. If that's not needed, please Squash&merge instead.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5044

-- Commit Summary --

  * Changesets: avoid calling json.partial! in loop
  * Messages: avoid calling json.partial! in loop
  * Users: avoid calling json.partial! in loop
  * Users: avoid calling json.partial! in loop

-- File Changes --

    M app/views/api/changesets/index.json.jbuilder (4)
    M app/views/api/messages/inbox.json.jbuilder (4)
    M app/views/api/messages/outbox.json.jbuilder (4)
    M app/views/api/notes/index.json.jbuilder (4)
    M app/views/api/users/index.json.jbuilder (4)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5044.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5044.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5044
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5044 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240804/c9eae94d/attachment-0001.htm>


More information about the rails-dev mailing list