[openstreetmap/openstreetmap-website] Changeset: avoid XML rendering in loop (PR #5045)

[Anton Khorev]

@AntonKhorev commented on this pull request.



>  xml.osm(OSM::API.new.xml_root_attributes) do |osm|
-  @changesets.each do |changeset|
-    osm << render(changeset)
-  end
+  osm << (render(@changesets) || "")

Looks like it was needed at some point in a similar situation: https://github.com/openstreetmap/openstreetmap-website/commit/925bd812a2c9000c4901384b70f20e65b0f53cd4

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5045#discussion_r1704749176
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5045/review/2220040580 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240805/2e23811f/attachment.htm>