[openstreetmap/openstreetmap-website] Changeset: avoid XML rendering in loop (PR #5045)

[mmd]

@mmd-osm commented on this pull request.



>  xml.osm(OSM::API.new.xml_root_attributes) do |osm|
-  @changesets.each do |changeset|
-    osm << render(changeset)
-  end
+  osm << (render(@changesets) || "")

I haven't checked  the other places if it's really needed there. It could be that it was required some 10 years ago, and never revisited if that's still the case.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5045#discussion_r1705801792
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5045/review/2221737906 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240806/5d1f4d20/attachment.htm>