[openstreetmap/openstreetmap-website] Move directions endpoints code to its own module (PR #5062)
Anton Khorev
notifications at github.com
Sat Aug 10 03:46:44 UTC 2024
Continues #4902. Apparently it's too tempting to put the routing logic back into endpoints code (https://github.com/openstreetmap/openstreetmap-website/pull/4904#pullrequestreview-2228123839, https://github.com/openstreetmap/openstreetmap-website/pull/4904#pullrequestreview-2230576231). Moving the code to another file will hopefully dissuade that.
You can view, comment on, or merge this pull request online at:
https://github.com/openstreetmap/openstreetmap-website/pull/5062
-- Commit Summary --
* Remove references to global variables from endpoint drag listener
* Rename route request variable
* Move endpoints code to its own module
-- File Changes --
A app/assets/javascripts/index/directions-endpoint.js (84)
M app/assets/javascripts/index/directions.js (109)
-- Patch Links --
https://github.com/openstreetmap/openstreetmap-website/pull/5062.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5062.diff
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5062
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5062 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240809/2cfec93e/attachment-0001.htm>
More information about the rails-dev
mailing list