[openstreetmap/openstreetmap-website] Move directions endpoints code to its own module (PR #5062)
Anton Khorev
notifications at github.com
Sun Aug 11 00:46:59 UTC 2024
I'm not fixing #2982 here yet. Fixing it would require answering https://github.com/openstreetmap/openstreetmap-website/pull/4904#issuecomment-2211735073. Do we actually need reverse geocoding? As I understand, #4904 tries to keep doing reverse geocoding in the same situations as before. Picked "Directions from here" from context menu? Do reverse geocoding. Dragged an endpoint marker? Don't do reverse geocoding. But why like that? Why not the other way around or never or always? The answers that make sense are:
- Never do reverse geocoding. But that may look like we're removing a feature that some people use.
- Do it if the user requests. This will require adding some button near or inside the from/to inputs.
- Always do it. This actually makes most sense. The endpoint module can handle this internally. It doesn't have to report if this operation succeeded to the outside code.
--
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5062#issuecomment-2282331916
You are receiving this because you are subscribed to this thread.
Message ID: <openstreetmap/openstreetmap-website/pull/5062/c2282331916 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240810/df61cdf1/attachment-0001.htm>
More information about the rails-dev
mailing list