[openstreetmap/openstreetmap-website] Simplify routing endpoint interface, always do reverse geocoding (PR #5064)

[Nenad Vujicic]

Thanks for great PR! The sources are now much more readable and it seems a lot of bugs are fixed.

Just a few remarks:

1. Perhaps it would be good to fit map's bounds (directions.js Ln 159) on union of markers and route polyline (instead of route polyline only). 2 cases when this is useful: 
a) at least one (or both) of markers are too far from retrieved route and they are not visible in final display and
b) routing engine was unable to return the route (e.g. place markers at (0,0) and (1,1)) and only markers are displayed (but, if you type them, map didn't focus on them).

2. It seems we still have duplicated calls to nominatim when we select from context menu (other cases are OK). Please, take a look at below video:

https://github.com/user-attachments/assets/2f7a4ed8-1e82-4eb4-becf-fd28a7c3e05c

Anyway, even with above remarks, I think this is great PR. Thanks for making it!

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5064#issuecomment-2285981589
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5064/c2285981589 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240813/b445118c/attachment.htm>