[openstreetmap/openstreetmap-website] Remove setLatLng() from directions endpoint interface (PR #5072)

Anton Khorev notifications at github.com
Wed Aug 14 02:27:18 UTC 2024


This is a smaller part of #5064 that can be applied independently.

Instead of two methods to pass values/positions to endpoint (`setValue`, `setLatLng`) you get one, `setValue`. `setValue` after this PR has two arguments, `value` and `latlng`, and the next step is to remove `latlng` and let the endpoint figure out itself if `value` contains coordinates or if it doesn't.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5072

-- Commit Summary --

  * Don't call endpoint.setLatLng() from outside of endpoint module
  * Don't set input value from endpoint.setLatLng()
  * Make setLatLng a private function

-- File Changes --

    M app/assets/javascripts/index/directions-endpoint.js (23)
    M app/assets/javascripts/index/directions.js (4)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5072.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5072.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5072
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5072 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240813/2fb96207/attachment.htm>


More information about the rails-dev mailing list