[openstreetmap/openstreetmap-website] Add social sharing functionality (PR #4985)

[Anton Khorev]

@AntonKhorev commented on this pull request.



> +      :div,
+      :class => "social-share-button d-flex gap-1 align-items-end flex-wrap",
+      :data => {
+        :title => opts[:title],
+        :url => opts[:url],
+        :desc => opts[:desc],
+        :via => opts[:via]
+      }
+    ) do
+      social_buttons = valid_sites.filter_map do |site|
+        if SocialShareButtonHelper.icon_path(site).empty?
+          Rails.logger.error("Invalid site: #{site}")
+          next
+        end
+
+        link_to "", {

Why do links to social media have to be generated by javascript instead of being available here?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4985#pullrequestreview-2237134504
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4985/review/2237134504 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240813/3044482b/attachment-0001.htm>