[openstreetmap/openstreetmap-website] Don't call getGeocode from getRoute (PR #5083)

Anton Khorev notifications at github.com
Fri Aug 16 06:07:34 UTC 2024


Part of #5064.

`getRoute` shouldn't know anything about geocoding, doesn't need to wait for every kind of geocoding (namely for reverse one), therefore shouldn't command the endpoints to do it. All necessary geocoding is triggered by `endpoint.setValue` and input event listeners.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5083

-- Commit Summary --

  * Remove endpoint.hasGeocode state and related getRoute code
  * Move empty value check out of endpoint.getGeocode
  * Make getGeocode a private function

-- File Changes --

    M app/assets/javascripts/index/directions-endpoint.js (16)
    M app/assets/javascripts/index/directions.js (12)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5083.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5083.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5083
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5083 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240815/862c0139/attachment.htm>


More information about the rails-dev mailing list