[openstreetmap/openstreetmap-website] Copy "From" endpoint value to search input when closing directions (PR #5088)

Anton Khorev notifications at github.com
Fri Aug 16 15:56:57 UTC 2024


When you close the directions form there's this code that tries to use the "From" value for searching.
![image](https://github.com/user-attachments/assets/01b267fa-2db9-4631-866c-076919d1b6ef)

It does so by opening the url `/?query=...`. The url is wrong, it should be `/search?query=...`, thus nothing happens.

I could have fixed it by using `/search?query=...`, but I don't like that it runs the search right away, when the close button is clicked. Instead I set the search input value.

![image](https://github.com/user-attachments/assets/6cddbbc6-64b1-4892-9574-3fca69c5f337)

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5088

-- Commit Summary --

  * Copy "From" endpoint value to search input when closing directions

-- File Changes --

    M app/assets/javascripts/index/directions.js (8)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5088.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5088.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5088
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5088 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240816/a77156df/attachment.htm>


More information about the rails-dev mailing list