[openstreetmap/openstreetmap-website] Move changeset comments feed to resourceful routes (PR #4587)

Andy Allan notifications at github.com
Wed Aug 21 17:19:34 UTC 2024


@gravitystorm requested changes on this pull request.

Sorry for the delay in re-reviewing!

> @@ -16,7 +16,7 @@ def initialize(user)
 
     if Settings.status != "database_offline"
       can [:index, :feed, :show], Changeset
-      can :index, ChangesetComment
+      can :show, :changeset_comments_feed

As before, I don't think this is the correct action. This isn't a single object, it's a list of objects, so the method should be `index` to reflect this.

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4587#pullrequestreview-2251460916
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4587/review/2251460916 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240821/614d4006/attachment-0001.htm>


More information about the rails-dev mailing list