[openstreetmap/openstreetmap-website] Convert dashboard test into a system test (PR #5107)

[Anton Khorev]

Addresses https://github.com/openstreetmap/openstreetmap-website/pull/5070#issuecomment-2304501335 about `dashboards_controller_test.rb`. I converted the test into a system test because this way it's easier to test for the displayed content. I'm checking for "You have not added any friends" where previously was no assertion. Also I don't rely on a html element id that was used only for testing.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5107

-- Commit Summary --

  * Remove outdated test for friends in users controller
  * Change dashboard heading levels
  * Convert dashboard test into a system test

-- File Changes --

    M app/views/dashboards/show.html.erb (6)
    M test/controllers/dashboards_controller_test.rb (24)
    M test/controllers/users_controller_test.rb (3)
    A test/system/dashboard_test.rb (27)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5107.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5107.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5107
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5107 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240822/8afe73d4/attachment.htm>