[openstreetmap/openstreetmap-website] Remove revoke block action (PR #5110)

Anton Khorev notifications at github.com
Fri Aug 23 10:49:19 UTC 2024


After #5104 you can edit any block you can revoke, therefore you don't need a dedicated revoke page/action. Revoke pages are worse edit pages that don't let you edit the block message.
You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5110

-- Commit Summary --

  * Stop testing revoke block buttons
  * Remove revoke buttons from block lists
  * Remove revoke buttons from block show pages
  * Update block-api integration test to revoke block by editing
  * Remove revoke block pages
  * Remove revoke block action

-- File Changes --

    M app/abilities/ability.rb (2)
    M app/controllers/user_blocks_controller.rb (13)
    M app/views/user_blocks/_block.html.erb (3)
    M app/views/user_blocks/_blocks.html.erb (3)
    D app/views/user_blocks/revoke.html.erb (31)
    M app/views/user_blocks/show.html.erb (11)
    M config/locales/en.yml (10)
    M config/routes.rb (1)
    M test/controllers/user_blocks_controller_test.rb (64)
    M test/integration/user_blocks_test.rb (7)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5110.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5110.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5110
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5110 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240823/5dc73374/attachment.htm>


More information about the rails-dev mailing list