[openstreetmap/openstreetmap-website] Add pagination to Issues page (PR #5057)

[David Tsiklauri]

@nertc commented on this pull request.



> +    end
+
+    sign_in_as(create(:administrator_user))
+
+    visit issues_path
+
+    # First Page
+    assert_no_content I18n.t("issues.index.user_not_found")
+    assert_no_content I18n.t("issues.index.issues_not_found")
+    assert_css "tr", :count => 51
+
+    # Second Page
+    click_on I18n.t("issues.page.older_issues")
+    assert_no_content I18n.t("issues.index.user_not_found")
+    assert_no_content I18n.t("issues.index.issues_not_found")
+    assert_css "tr", :count => 31, :wait => 1.5

When I run this test on my local machine, it succeeds even without `:wait`. But when I was pushing it to the GitHub, workflow tests were failing, because they were not waiting for paginated pages to be rendered. That's why I added `:wait`. Maybe there is some difference in the default waiting time configuration. I checked default_max_wait_time on my local machine and it was 2 (it's even more than the hardcoded 1.5).

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5057#discussion_r1731601532
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5057/review/2261266888 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240826/edc1803f/attachment.htm>