[openstreetmap/openstreetmap-website] Refactor error layout with small styling enchancments (PR #5130)

Fri Aug 30 00:31:47 UTC 2024

@AntonKhorev commented on this pull request.

> @@ -4,14 +4,19 @@
     <meta charset="utf-8">
     <title>OpenStreetMap</title>
     <%= stylesheet_link_tag "errors", :media => "screen" %>
-    <%= render :partial => "layouts/meta" %>
+    <%= render :partial => "layouts/head" %>

`<head>` inside `<head>`?

You're proposing to load everything on 404 pages: jquery, leaflet, bootstrap, turbo etc. And you're doing this to set max width and add one link styled as a button, right?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5130#pullrequestreview-2270690394
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5130/review/2270690394 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240829/f0e3418e/attachment.htm>