[openstreetmap/openstreetmap-website] Update error pages (PR #5131)

Anton Khorev notifications at github.com
Fri Aug 30 02:32:58 UTC 2024


You can debate what changes are needed on error pages.  #5130 does some, referring to #3532, but that issue proposes some things I wouldn't agree with.

For comparison here's what I'd change.

![image](https://github.com/user-attachments/assets/a0a7e256-7d0d-4e90-8e0e-7769bbc904bd)
![image](https://github.com/user-attachments/assets/de82a4d9-26f4-4e01-8ece-74673c889e34)

You can view, comment on, or merge this pull request online at:

  https://github.com/openstreetmap/openstreetmap-website/pull/5131

-- Commit Summary --

  * Move http-equiv and viewport meta tags to meta template
  * Use system font on error pages
  * Adjust logo css on error pages
  * Use flex layout on error pages

-- File Changes --

    M app/assets/stylesheets/errors.scss (45)
    M app/views/layouts/_head.html.erb (4)
    M app/views/layouts/_meta.html.erb (2)
    M app/views/layouts/error.html.erb (14)

-- Patch Links --

https://github.com/openstreetmap/openstreetmap-website/pull/5131.patch
https://github.com/openstreetmap/openstreetmap-website/pull/5131.diff

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5131
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5131 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20240829/3eca09ac/attachment.htm>


More information about the rails-dev mailing list