[openstreetmap/openstreetmap-website] Add social sharing functionality (PR #4985)

Anton Khorev notifications at github.com
Sat Dec 7 12:33:22 UTC 2024


@AntonKhorev requested changes on this pull request.



> @@ -1,3 +1,5 @@
+ <%= javascript_include_tag "social_share_button" %>

```suggestion
<% content_for :head do %>
  <%= javascript_include_tag "social_share_button" %>
<% end %>
```

That's how we do it, for example, in https://github.com/openstreetmap/openstreetmap-website/blob/fe81ac334cfef04751a959297dca24e472cb025f/app/views/dashboards/show.html.erb#L13-L15

> @@ -44,4 +44,5 @@
       <% end %>
     </ul>
   </nav>
+

We probably don't need to touch this file?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/4985#pullrequestreview-2486491718
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/4985/review/2486491718 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241207/0daa6246/attachment.htm>


More information about the rails-dev mailing list