[openstreetmap/openstreetmap-website] Add profile location (PR #5302)

Anton Khorev notifications at github.com
Sat Dec 7 13:40:16 UTC 2024


@AntonKhorev commented on this pull request.



> +    if (!locationInput.dirty || locationName.includes(locationInput.countryName)) {
+      $("#location_name_warning").addClass("d-none");
+    } else {
+      $("#location_name_warning").removeClass("d-none");
+    }

Wouldn't using jQuery's `show` / `hide` / `toggle` be simpler than manipulating classes?

-- 
Reply to this email directly or view it on GitHub:
https://github.com/openstreetmap/openstreetmap-website/pull/5302#pullrequestreview-2486502551
You are receiving this because you are subscribed to this thread.

Message ID: <openstreetmap/openstreetmap-website/pull/5302/review/2486502551 at github.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.openstreetmap.org/pipermail/rails-dev/attachments/20241207/3b555e74/attachment.htm>


More information about the rails-dev mailing list